Added upsert support for mongodb.SetVersion function #803
Conversation
dhui
left a comment
dhui
left a comment
There was a problem hiding this comment.
Thanks for the PR and thanks for fixing the linter errors!
| } | ||
| _, err := migrationsCollection.InsertOne(context.TODO(), bson.M{"version": version, "dirty": dirty}) | ||
| opts := options.Update().SetUpsert(true) | ||
| _, err := migrationsCollection.UpdateOne(context.TODO(), bson.M{}, bson.D{{Key: "$set", Value: bson.M{"version": version, "dirty": dirty}}}, opts) |
There was a problem hiding this comment.
Will this work with existing DBs? e.g. how does this update existing entries?
Right now, there's only ever one document in the migrations collection.
There was a problem hiding this comment.
Yes @dhui, it is working with existing entries in DB. I tested it by adding some sleep between the SetVersion functions in migrate.js and monitored changes in the document. It updated the dirty flag for the existing entry and for the new version entry it replaced the document with a new document. At the end of the migration, the collection contained only a single document.
|
Hello Team, Please review and let me know if anything more is needed from my end. Thanks, |
3 participants
Resolves #779