Skip to content

chore(queue): don't allocate new message #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2023
Merged

chore(queue): don't allocate new message #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
chore(queue): don'r alocate new message 
Signed-off-by: Bo-Yi.Wu <[email protected]>
  • Loading branch information
@appleboy
appleboy committed Jan 29, 2023
commit b477a3ef2ef21acea2d5bde5d7d37f9ddd7582d4
9 changes: 9 additions & 0 deletions job/job.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,15 @@ func (m *Message) Encode() []byte {
return b
}

// Rest for reset default value
func (m *Message) Rest() {
m.Task = nil
m.Payload = nil
m.RetryCount = 0
m.Timeout = 0
m.RetryDelay = 0
}

func NewMessage(m core.QueuedMessage, opts ...AllowOption) *Message {
o := NewOptions(opts...)

Expand Down
7 changes: 4 additions & 3 deletions queue.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,10 +120,11 @@ func (q *Queue) Queue(m core.QueuedMessage, opts ...job.AllowOption) error {
}

message := job.NewMessage(m, opts...)
payload := message.Encode()
message.Rest()
message.Payload = payload

if err := q.worker.Queue(&job.Message{
Payload: message.Encode(),
}); err != nil {
if err := q.worker.Queue(message); err != nil {
return err
}

Expand Down