Skip to content

ssh: add (*Client).DialContext method #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ydnar wants to merge 6 commits into from
Closed

ssh: add (*Client).DialContext method #260

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d20da86
ssh: add (*Client).DialContext method
ydnar Jun 21, 2023
9207fc3
ssh: CL feedback
ydnar Jun 21, 2023
58d8177
ssh: CL feedback: show that net.Dialer also implements ContextDialer
ydnar Jun 21, 2023
d051e97
ssh: remove redundant test
ydnar Jun 21, 2023
ce9c179
ssh: CL feedback on test
ydnar Jun 22, 2023
3176984
empty commit
ydnar Jun 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ssh: CL feedback on test
  • Loading branch information
@ydnar
ydnar committed Jun 22, 2023
commit ce9c1793c51f61512a63715c2d880617d3ee45a7
47 changes: 16 additions & 31 deletions ssh/test/dial_unix_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,38 +48,23 @@ func testDial(t *testing.T, n, listenAddr string, x dialTester) {
}
}()

{
conn, err := sshConn.Dial(n, l.Addr().String())
if err != nil {
t.Fatalf("Dial: %v", err)
}
x.TestClientConn(t, conn)
defer conn.Close()
b, err := io.ReadAll(conn)
if err != nil {
t.Fatalf("ReadAll: %v", err)
}
t.Logf("got %q", string(b))
if string(b) != testData {
t.Fatalf("expected %q, got %q", testData, string(b))
}
ctx, cancel := context.WithCancel(context.Background())
conn, err := sshConn.DialContext(ctx, n, l.Addr().String())
// Canceling the context after dial should have no effect
// on the opened connection.
cancel()
if err != nil {
t.Fatalf("Dial: %v", err)
}

{
conn, err := sshConn.DialContext(context.Background(), n, l.Addr().String())
if err != nil {
t.Fatalf("Dial: %v", err)
}
x.TestClientConn(t, conn)
defer conn.Close()
b, err := io.ReadAll(conn)
if err != nil {
t.Fatalf("ReadAll: %v", err)
}
t.Logf("got %q", string(b))
if string(b) != testData {
t.Fatalf("expected %q, got %q", testData, string(b))
}
x.TestClientConn(t, conn)
defer conn.Close()
b, err := io.ReadAll(conn)
if err != nil {
t.Fatalf("ReadAll: %v", err)
}
t.Logf("got %q", string(b))
if string(b) != testData {
t.Fatalf("expected %q, got %q", testData, string(b))
}
}

Expand Down