x/tools/gopls: FoldingRange: VS Code displays no fold option for else/elseif block in if else stmt

[xieyuschen]

gopls version

Build info

golang.org/x/tools/gopls v0.0.0-20250904192731-a09a2fba1c08
golang.org/x/tools/gopls@v0.0.0-20250904192731-a09a2fba1c08
github.com/BurntSushi/toml@v1.5.0 h1:W5quZX/G/csjUnuI8SUYlsHs9M38FC7znL0lIO+DvMg=
github.com/fatih/camelcase@v1.0.0 h1:hxNvNX/xYBp0ovncs8WyWZrOrpBNub/JfaMvbURyft8=
github.com/fatih/gomodifytags@v1.17.1-0.20250423142747-f3939df9aa3c h1:dDSgAjoOMp8da3egfz0t2S+t8RGOpEmEXZubcGuc0Bg=
github.com/fatih/structtag@v1.2.0 h1:/OdNE99OxoI/PqaW/SuSK9uxxT3f/tcSZgon/ssNSx4=
github.com/fsnotify/fsnotify@v1.9.0 h1:2Ml+OJNzbYCTzsxtv8vKSFD9PbJjmhYF14k/jKC7S9k=
github.com/google/go-cmp@v0.7.0 h1:wk8382ETsv4JYUZwIsn6YpYiWiBsYLSJiTsyBybVuN8=
golang.org/x/exp/typeparams@v0.0.0-20250718183923-645b1fa84792 h1:54/e+WfmhvjR2Zuz8Q7dzLGxIBM+s5WZpvo1QfVDGB8=
golang.org/x/mod@v0.27.0 h1:kb+q2PyFnEADO2IEF935ehFUXlWiNjJWtRNgBLSfbxQ=
golang.org/x/sync@v0.16.0 h1:ycBJEhp9p4vXvUZNszeOq0kGTPghopOL8q0fq3vstxw=
golang.org/x/sys@v0.35.0 h1:vz1N37gP5bs89s7He8XuIYXpyY0+QlsKmzipCbUtyxI=
golang.org/x/telemetry@v0.0.0-20250807160809-1a19826ec488 h1:3doPGa+Gg4snce233aCWnbZVFsyFMo/dR40KK/6skyE=
golang.org/x/text@v0.28.0 h1:rhazDwis8INMIwQ4tpjLDzUhx6RlXqZNPEM0huQojng=
golang.org/x/tools@v0.35.0 => ../
golang.org/x/vuln@v1.1.4 h1:Ju8QsuyhX3Hk8ma3CesTbO8vfJD9EvUBgHvkxHBzj0I=
honnef.co/go/tools@v0.7.0-0.dev.0.20250523013057-bbc2f4dd71ea h1:fj8r9irJSpolAGUdZBxJIRY3lLc4jH2Dt4lwnWyWwpw=
mvdan.cc/gofumpt@v0.8.0 h1:nZUCeC2ViFaerTcYKstMmfysj6uhQrA2vJe+2vwGU6k=
mvdan.cc/xurls/v2@v2.6.0 h1:3NTZpeTxYVWNSokW3MKeyVkz/j7uYXYiMtXRUfmjbgI=
go: go1.25.1

go env

irrelevant

What did you do?

func _() {
	if true {

	} else {
		// else block is not foldable.
	}

	if true {

	} else if true {
		// else-if block is not foldable.
	} else {

	}
}

What did you see happen?

• if-else case: else cannot be fold
• if-elseif-else case: elseif cannot be fold

What did you expect to see?

Both of cases above should be supported; we should support fold as this(screenshot is in typescript). How do you think about it? @findleyr @adonovan @h9jiang

Editor and settings

No response

Logs

No response

[xieyuschen]

I can help to support it if you think that's reasonable, please assign the issue to me(don't have permission to assign myself yet).

[gabyhelp]

Related Issues

• x/tools/gopls: iferr completion content should adjust according to return type of function in scope #65885
• x/tools/gopls: provide foldingRange for the case sections within a select #40146 (closed)
• x/tools/gopls: Unexpected line comment insertion after line break #74618 (closed)
• x/tools/gopls: `func` snippet not provided when `func` is written #74802
• x/tools/gopls: semantic tokens: highlight control flow tokens #67663 (closed)
• x/tools/gopls: missing semantic tokens for function parameters in block #56257 (closed)
• x/tools/gopls: FoldingRange omitempty causes EndCharacter=0 to be omitted, changing its semantics in clients that distinguish 0 from missing #71489 (closed)
• x/tools/gopls: InvalidRangeExpr when using GOEXPERIMENT=rangefunc on iter.Seq #65667 (closed)
• x/tools/gopls: snippets do not replace triggering preamble #59508 (closed)
• x/tools/gopls: incorrect code generated by "Extract function" #73972 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[madelinekalil]

Thanks for the report! Yes, we should support folding ranges for the additional cases you mentioned. Feel free to pick this up

[xieyuschen]

Interactive test result for CL 704096.

• before:

• after:

[gopherbot]

Change https://go.dev/cl/704096 mentions this issue: gopls/internal/golang: improve if-else folding range for vscode

[adonovan]

$ nl -ba ./a.go 
     1	package tools
     2	
     3	func _() {
     4		if true {
     5	
     6		} else {
     7			// else block is not foldable.
     8		}
     9	
    10		if true {
    11	
    12		} else if true {
    13			// else-if block is not foldable.
    14		} else {
    15	
    16		}
    17	}

$ gopls folding_ranges ./a.go 
3:11-17:1
4:11-6:2
6:10-8:2
10:11-12:2
12:18-14:2
14:10-16:2

It looks like gopls is producing exactly the right information. Isn't this a bug in VS Code?

[xieyuschen]

gopls response is correct, I will help check how vscode handles it(bug or feature)?

[Trace - 13:25:20.789 PM] Sending request 'textDocument/foldingRange - (931)'.
Params: {"textDocument":{"uri":"file:///Users/yuchen.xie/workspace/demos/mod/cron/a.go"}}


[Trace - 13:25:20.789 PM] Received response 'textDocument/foldingRange - (931)' in 0ms.
Result: [{"startLine":2,"startCharacter":10,"endLine":17,"endCharacter":0},{"startLine":3,"startCharacter":10,"endLine":5,"endCharacter":1},{"startLine":5,"startCharacter":9,"endLine":7,"endCharacter":1},{"startLine":10,"startCharacter":10,"endLine":12,"endCharacter":1},{"startLine":12,"startCharacter":17,"endLine":14,"endCharacter":1},{"startLine":14,"startCharacter":9,"endLine":16,"endCharacter":1}]