Skip to content

Update staticcheck to v0.1.2 (2020.2.2) #1756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 21, 2021
Merged

Update staticcheck to v0.1.2 (2020.2.2) #1756

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
27e08e3
chore: update dependency.
ldez Dec 31, 2020
86df4e3
feat: new unused implementation.
ldez Dec 31, 2020
de3f2b5
chore: apply new staticheck rules.
ldez Dec 31, 2020
868574a
add exclude-rules to be compatible with the previous golanci-lint ver…
ldez Feb 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: apply new staticheck rules.
  • Loading branch information
@ldez
ldez committed Feb 21, 2021
commit de3f2b5e969c77431a0534e19da83064c6f8361d
2 changes: 1 addition & 1 deletion pkg/golinters/depguard.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (

"github.com/OpenPeeDeeP/depguard"
"golang.org/x/tools/go/analysis"
"golang.org/x/tools/go/loader"
"golang.org/x/tools/go/loader" //nolint:staticcheck // require changes in github.com/OpenPeeDeeP/depguard

"github.com/golangci/golangci-lint/pkg/golinters/goanalysis"
"github.com/golangci/golangci-lint/pkg/lint/linter"
Expand Down
2 changes: 1 addition & 1 deletion pkg/golinters/goanalysis/adapters.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import (
"go/types"

"golang.org/x/tools/go/analysis"
"golang.org/x/tools/go/loader"
"golang.org/x/tools/go/loader" //nolint:staticcheck // it's an adapter for golang.org/x/tools/go/packages
)

func MakeFakeLoaderProgram(pass *analysis.Pass) *loader.Program {
Expand Down
2 changes: 1 addition & 1 deletion test/testdata/staticcheck.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ func StaticcheckNolintMegacheck() {
}

func StaticcheckDeprecated() {
_ = runtime.CPUProfile() // ERROR "SA1019: runtime.CPUProfile is deprecated"
_ = runtime.CPUProfile() // ERROR "SA1019: runtime.CPUProfile has been deprecated .*"
}

func StaticcheckPrintf() {
Expand Down