Skip to content

Add dimissKeyboard to Swift interface #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
minuscorp wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add dimissKeyboard to Swift interface #747

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add dimissKeyboard to Swift interface
  • Loading branch information
@minuscorp
minuscorp authored Sep 5, 2018
commit 0339f723869e2bb4dab3da93006109e998724f1a
8 changes: 8 additions & 0 deletions gem/lib/earlgrey/files/Swift-4.0/EarlGrey.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,14 @@ open class EarlGrey: NSObject {
.rotateDevice(to: orientation,
errorOrNil: errorOrNil)
}

Copy link
Collaborator

@khandpur khandpur Sep 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great. do you mind adding a test that uses this as well?

Copy link
Author

@minuscorp minuscorp Sep 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any test suite that tests the swift implementations? I've just found the Objective-C ones 😅

Copy link
Collaborator

@khandpur khandpur Sep 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry you're right. How about here: https://github.com/google/EarlGrey/blob/master/Demo/EarlGreyExample/EarlGreyExampleSwiftTests/EarlGreyExampleSwiftTests.swift ?

Copy link
Author

@minuscorp minuscorp Sep 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't promise nothing until the weekend, but I'll try to make it work 😄

Copy link
Author

@minuscorp minuscorp Sep 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, why does the build fail? 🤔

Copy link
Collaborator

@khandpur khandpur Sep 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those look like legitimate test failures unrelated to your change.

@tirodkar mind taking a look?

@discardableResult open class func dismissKeyboard(errorOrNil: UnsafeMutablePointer<NSError?>!,
file: StaticString = #file,
line: UInt = #line)
-> Bool {
return EarlGreyImpl.invoked(fromFile: file.description, lineNumber: line)
.dismissKeyboardWithError(errorOrNil)
}
}

extension GREYInteraction {
Expand Down