Skip to content

Add the option to choose additional scopes at sign-in #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
petea merged 6 commits into from
Mar 8, 2022
Merged

Add the option to choose additional scopes at sign-in #30

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a78d06e
fix calling callback on addScopes
AntonKozlovskyi Jul 19, 2021
ddcdeee
Add possibility to choose scopes in time of sign in
AntonKozlovskyi Jul 19, 2021
cba34eb
fixes due review
AntonKozlovskyi Jul 19, 2021
2009f93
Merge branch 'main' into ScopesOnLogin
AntonKozlovskyi Jul 20, 2021
83641ae
Merge branch 'main' into ScopesOnLogin
petea Mar 8, 2022
0197661
Complete merge from main
petea Mar 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix calling callback on addScopes
  • Loading branch information
@AntonKozlovskyi
AntonKozlovskyi authored and Anton Kozlovskyi committed Jul 19, 2021
commit a78d06ea01d5717282ed524171992537ab11bc7c
7 changes: 4 additions & 3 deletions GoogleSignIn/Sources/GIDSignIn.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,10 +690,11 @@ - (void)addCompletionCallback:(GIDAuthFlow *)authFlow {
[authFlow addCallback:^() {
GIDAuthFlow *handlerAuthFlow = weakAuthFlow;
if (self->_currentOptions.callback) {
dispatch_async(dispatch_get_main_queue(), ^{
self->_currentOptions.callback(self->_currentUser, handlerAuthFlow.error);
GIDSignInCallback callback = [self->_currentOptions.callback copy];
self->_currentOptions = nil;
});
dispatch_async(dispatch_get_main_queue(), ^{
callback(self->_currentUser, handlerAuthFlow.error);
});
}
}];
}
Expand Down