-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Support custom service account for agent engine via CLI #2969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @yazeedbashammakh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances the adk CLI
by enabling the specification of a custom Google Cloud service account when deploying an agent to the Agent Engine. This provides greater control over the permissions and identity of deployed agents, allowing for more secure and flexible deployments. Users can now define the service account either directly via a new command-line option or through an environment variable.
Highlights
- New CLI Option: Introduced a
--service_account
option to theadk deploy agent_engine
command, allowing users to specify a custom Google Cloud service account for their deployed agents. - Environment Variable Support: The deployment process now checks for a
GOOGLE_CLOUD_SERVICE_ACCOUNT
environment variable in.env
files, with the CLI option taking precedence if both are provided. - Agent Engine Configuration: The specified service account is now correctly passed and applied to the Agent Engine configuration during deployment, ensuring agents run with the desired permissions.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands on the current page.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Response from ADK Triaging Agent Hello @yazeedbashammakh, thank you for creating this PR! To help us review your contribution, could you please:
You can find more details in our contribution guidelines. This information will help reviewers to review your PR more efficiently. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for specifying a custom service account when deploying an agent to the agent engine via the ADK CLI. The changes look good overall, introducing a new --service_account
option and handling the corresponding environment variable GOOGLE_CLOUD_SERVICE_ACCOUNT
.
I've added a few comments with suggestions to improve documentation, code consistency, and maintainability. Specifically, I've recommended enhancing a docstring and addressing code duplication and a formatting issue in a log message.
Response from ADK Triaging Agent Hello @yazeedbashammakh, thank you for associating the issue with this PR! To help us review your contribution, could you please also:
You can find more details in our contribution guidelines. This information will help reviewers to review your PR more efficiently. Thanks! |
This PR will enable the custom service account while deploying agent to agent engine usin adk CLI.
Added --service_account option to
adk deploy agent_engine
command.Closes #2951
Performed complete end to end testing for this feature. I covered below 2 scenarios:
Deployed my agent using below CLI command:

This deployed the agent to agent engine without custom service account. We can verify this by calling REST API and getting details of deployed agent:
Deployed my agent using below CLI command:
It deployed my agent with my given custom service account. Again verified this by getting agent details using REST API call.

Custom service account is correctly assigned to the deployed agent.