Move native build logic to a Kotlin class. #1388
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No functional change but removes some cruft from the openjdk build.gradle. BoringSSL build directory is still a bit of a hack but I'll address that in a later, smaller PR.
prbprbprb
force-pushed
the
02_native_build
branch
from
23fce9c to
3d914da
Compare
prbprbprb
force-pushed
the
02_native_build
branch
from
8e46d1c to
dba4a75
Compare
Contributor
Author
|
CI passes in my fork of Conscrypt, module what looks like some flaky MacOS runners: https://github.com/prbprbprb/conscrypt/actions/runs/18162969691 |
Contributor
Author
|
Any chance we could try and land this? As I have some ARM Linux patches which depend on it... As stated, it only affects Gradle builds and there are no functional changes to Conscrypt itself. |
Contributor
Author
|
I'll split this for ease of review. One PR with just the new code (plus more tests and preconditions than this PR), followed by a second one to migrate openjdk/build to it. Leaving this PR as a draft as a reference point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional change but removes some cruft from the openjdk build.gradle.
This is stacked on top of #1386 and I'll leave it as a draft until that one lands, at which point it should become much smaller.