Skip to content

TypeParameterUnusedInFormals: Replace .bound by .getUpperBound() #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
don-vip wants to merge 1 commit into from
Closed

TypeParameterUnusedInFormals: Replace .bound by .getUpperBound() #1225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
TypeParameterUnusedInFormals: Replace .bound by .getUpperBound() 
See #1106 - field removed in JDK13 as per
http://hg.openjdk.java.net/jdk/jdk/rev/a772e65727c5#l1.23
  • Loading branch information
@don-vip
don-vip committed Feb 11, 2019
commit 1dcdb098e883855e84ae712c39841a47c5e96f21
6 changes: 3 additions & 3 deletions core/src/main/java/com/google/errorprone/bugpatterns/TypeParameterUnusedInFormals.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ public Description matchMethod(MethodTree tree, VisitorState state) {

// Ignore f-bounds.
// e.g.: <T extends Enum<T>> T unsafeEnumDeserializer();
if (retType.bound != null && TypeParameterFinder.visit(retType.bound).contains(retType.tsym)) {
if (retType.getUpperBound() != null && TypeParameterFinder.visit(retType.getUpperBound()).contains(retType.tsym)) {
return Description.NO_MATCH;
}

Expand Down Expand Up @@ -141,8 +141,8 @@ public Void visitTypeVar(Type.TypeVar type, Void unused) {
if (!seen.add(type.tsym)) {
return null;
}
if (type.bound != null) {
type.bound.accept(this, null);
if (type.getUpperBound() != null) {
type.getUpperBound().accept(this, null);
}
return null;
}
Expand Down