Moe Sync#1261

Merged

ronshapiro merged 35 commits intomasterfrom

sync-master-2019/04/15

Apr 18, 2019

Commits on Apr 16, 2019

Test case for guardedbychecker bug.

clm
authored and
ronshapiro
committed
RELNOTES: Enable AnnotateFormatMethod by default, and add a strong warning.

graememorgan
authored and
ronshapiro
committed
Add fixes for incompatible/required modifiers checks

cushon
authored and
ronshapiro
committed
Delete DeprecatedThreadMethods in favour of general-purpose deprecation warnings

cushon
authored and
ronshapiro
committed
New error for reference equality on boxed primitives

cushon
authored and
ronshapiro
committed
Support renaming fields in renameVariable

cushon
authored and
ronshapiro
committed
Add a defensive null-check

cushon
authored and
ronshapiro
committed
Make IncompatibleModifiers an error

cushon
authored and
ronshapiro
committed
Fix BadImport on ParameterizedType with TYPE_USE annotation

dx404
authored and
ronshapiro
committed
Add ModifySourceCollectionInStream check

dx404
authored and
ronshapiro
committed
Updated JavaTimeDefaultTimeZone to avoid NPE'ing when the function it

nick-someone
authored and
ronshapiro
committed
Add a check for local variables which are of boxed type but do not need to be

awturner
authored and
ronshapiro
committed
Provide suggestions for using Truth's Subject.check(...) in 3 cases:

cpovirk
authored and
ronshapiro
committed
Omit enclosing class names of constructors in diagnostics

cushon
authored and
ronshapiro
committed
Add a refactoring to replace trivial lambdas with method references

cushon
authored and
ronshapiro
committed
Clean up description creation

cushon
authored and
ronshapiro
committed
Use a prebuilt JDK 7 -> 8 API diff

cushon
authored and
ronshapiro
committed
New a check to simplify description creation

cushon
authored and
ronshapiro
committed
Handle casts in SelfAssignment

cushon
authored and
ronshapiro
committed
Don't complain about deprecated java.lang.Compiler API in JavaLangClash

cushon
authored and
ronshapiro
committed
Clean up unnecessary lambdas

cushon
authored and
ronshapiro
committed
Add a WARNING for using .valueOf(String) on lite proto buffer enums

sumitbhagwani
authored and
ronshapiro
committed
Return -> Returning

graememorgan
authored and
ronshapiro
committed
Open-source @DoNotMock

eaftan
authored and
ronshapiro
committed
Add Check for Leaking/Mutating an already-forked mutable instance (Bundle)

dx404
authored and
ronshapiro
committed
Add EmptyBlockTag error-prone check

ash211
authored and
ronshapiro
committed
Fix a crash in SelfAssignment

cushon
authored and
ronshapiro
committed
Revert some unnecessary changes

cushon
authored and
ronshapiro
committed
Add java.time.temporal.ValueRange#checkValidValue as a method that

nick-someone
authored and
ronshapiro
committed
Recognize that it's safe to migrate from == to isEqualTo() for enums.

cpovirk
authored and
ronshapiro
committed
In UnnecessaryLambda, don't refactor uses that call methods other than the descriptor

cushon
authored and
ronshapiro
committed
Update Gradle plugin check example

tbroyer
authored and
ronshapiro
committed
TypeParameterUnusedInFormals: Replace `.bound` by

don-vip
authored and
ronshapiro
committed
Fix for error-prone ImmutableEnumChecker warning

sumitbhagwani
authored and
ronshapiro
committed
Fix for error-prone AutoValueFinalMethods warning

sumitbhagwani
authored and
ronshapiro
committed