Skip to content

Set annotations on descriptors created by referrers API #2068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ilopezluna wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Set annotations on descriptors created by referrers API #2068

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b091e40
Set annotations on descriptors created by referrers API
nmiyake Aug 13, 2024
e089773
Verifies annotations are present in the descriptor
ilopezluna Feb 24, 2025
b74f1fa
Verifies annotations are present in the descriptor
ilopezluna Feb 24, 2025
bc1d9c6
Merge remote-tracking branch 'origin/fixReferrerAnnotations' into fix…
ilopezluna Feb 24, 2025
0040184
Merge branch 'main' into fixReferrerAnnotations
ilopezluna Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Verifies annotations are present in the descriptor
  • Loading branch information
@ilopezluna
ilopezluna committed Feb 24, 2025
commit e089773ea12fd509058741c4bfe02dbbd54db5b2
5 changes: 5 additions & 0 deletions pkg/v1/remote/referrers_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,11 @@ func TestReferrers(t *testing.T) {
t.Fatalf("referrers diff (-want,+got): %s", d)
}

// Verify the annotations are present in the descriptor
if got := m2.Manifests[0].Annotations["annotation-key"]; got != "annotation-value" {
t.Errorf("expected annotation 'annotation-key' to be 'annotation-value', got %q", got)
}

if leg.tryFallback {
// Get the referrers by querying the root image's fallback tag directly.
tag, err := name.ParseReference(fmt.Sprintf("%s/repo:sha256-%s", u.Host, rootDesc.Digest.Hex))
Expand Down