Skip to content

Remove use of distutils #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Remove use of distutils #680

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Remove use of distutils 
Distutils will be deprecated in python 3.12, see [PEP 632](https://www.python.org/dev/peps/pep-0632/).

`shutil.which` is the recommended replacement for `distutils.spawn.find_executable`.
  • Loading branch information
@nakulj
nakulj authored Nov 1, 2021
commit 48c041aa6d8aad5a29e4963e7f0eb062c5351939
4 changes: 2 additions & 2 deletions scripts/google-java-format-diff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
import subprocess
import io
import sys
from distutils.spawn import find_executable
from shutil import which

def main():
parser = argparse.ArgumentParser(description=
Expand Down Expand Up @@ -105,7 +105,7 @@ def main():
elif args.google_java_format_jar:
base_command = ['java', '-jar', args.google_java_format_jar]
else:
binary = find_executable('google-java-format') or '/usr/bin/google-java-format'
binary = which('google-java-format') or '/usr/bin/google-java-format'
base_command = [binary]

# Reformat files containing changes in place.
Expand Down