Fix data race in agent.Listen #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the following data race in agent.Listen:
==================
WARNING: DATA RACE
Write at 0x0000007620a0 by goroutine 9:
github.com/google/gops/agent.Listen()
/home/tklauser/go/src/github.com/google/gops/agent/agent.go:112 +0x207
github.com/google/gops/agent.TestAgentClose()
/home/tklauser/go/src/github.com/google/gops/agent/agent_test.go:21 +0x6e
testing.tRunner()
/usr/local/go/src/testing/testing.go:1439 +0x213
testing.(*T).Run.func1()
/usr/local/go/src/testing/testing.go:1486 +0x47
Previous read at 0x0000007620a0 by goroutine 8:
github.com/google/gops/agent.listen()
/home/tklauser/go/src/github.com/google/gops/agent/agent.go:130 +0x5a
Goroutine 9 (running) created at:
testing.(*T).Run()
/usr/local/go/src/testing/testing.go:1486 +0x724
testing.runTests.func1()
/usr/local/go/src/testing/testing.go:1839 +0x99
testing.tRunner()
/usr/local/go/src/testing/testing.go:1439 +0x213
testing.runTests()
/usr/local/go/src/testing/testing.go:1837 +0x7e4
testing.(*M).Run()
/usr/local/go/src/testing/testing.go:1719 +0xa71
main.main()
_testmain.go:57 +0x2e4
Goroutine 8 (finished) created at:
github.com/google/gops/agent.Listen()
/home/tklauser/go/src/github.com/google/gops/agent/agent.go:123 +0x43b
github.com/google/gops/agent.TestListen()
/home/tklauser/go/src/github.com/google/gops/agent/agent_test.go:13 +0x57
testing.tRunner()
/usr/local/go/src/testing/testing.go:1439 +0x213
testing.(*T).Run.func1()
/usr/local/go/src/testing/testing.go:1486 +0x47
==================
--- FAIL: TestAgentClose (0.00s)
testing.go:1312: race detected during execution of test
FAIL
FAIL github.com/google/gops/agent 0.026s
glibsm
approved these changes
Jul 7, 2022
odeke-em
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the data race in agent.Liste uncovered in #173 and run tests with
-racein CI.