Skip to content

include type arguments in reference elements's referencedName/toString #1737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

include type arguments in reference elements's referencedName/toString #1737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ...n/src/main/kotlin/com/google/devtools/ksp/symbol/impl/kotlin/KSClassifierReferenceImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,14 @@ class KSClassifierReferenceImpl private constructor(val ktUserType: KtUserType)
}

override fun referencedName(): String {
return ktUserType.referencedName ?: ""
val typeArgs = typeArguments
return if (typeArgs.isEmpty()) {
ktUserType.referencedName ?: ""
} else {
ktUserType.referencedName + typeArgs.joinToString(prefix = "<", postfix = ">") {
it.type?.toString() ?: "*"
}
}
}

override val qualifier: KSClassifierReference? by lazy {
Expand Down
2 changes: 1 addition & 1 deletion test-utils/testData/api/referenceElement.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
// TEST PROCESSOR: ReferenceElementProcessor
// EXPECTED:
// KSClassifierReferenceImpl: Qualifier of B is A
// KSClassifierReferenceImpl: Qualifier of C is A
// KSClassifierReferenceImpl: Qualifier of C<Int> is A<String>
// KSClassifierReferenceImpl: Qualifier of Int is null
// KSClassifierReferenceImpl: Qualifier of String is null
// KSClassifierReferenceDescriptorImpl: Qualifier of Int is null
Expand Down