Skip to content

feat!: use inspector for time profiles #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aabmass wants to merge 11 commits into
base: main
Choose a base branch
from
Open

feat!: use inspector for time profiles #227

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b9bab1c
feat!: use inspector for time profiles
aabmass Oct 21, 2022
f777979
Apply suggestions from code review
aabmass Oct 21, 2022
5663cff
Merge branch 'main' into use-inspector-cpu
aabmass Oct 24, 2022
6fd2c76
Small fixes
aabmass Oct 24, 2022
f411224
More fixes
aabmass Oct 24, 2022
e5dd21d
Merge branch 'main' into use-inspector-cpu
aabmass Oct 24, 2022
7211b6d
Strip file:/ prefixes from scriptNames and fixed system tests
aabmass Nov 2, 2022
b5483e3
Remove unnused options since we are already making breaking changes f…
aabmass Nov 2, 2022
c844b8d
Add todo for --require
aabmass Nov 2, 2022
b510c6e
Undo accidental edits to system test
aabmass Nov 2, 2022
3650dbc
Add explicit signatures to modified functions to make breaking change…
aabmass Nov 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add todo for --require
  • Loading branch information
@aabmass
aabmass committed Nov 2, 2022
commit c844b8d7ee9c6b56805e82514da11ac9dd70fbcb
4 changes: 2 additions & 2 deletions ts/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ if (module.parent && module.parent.id === 'internal/preload') {
// The process is going to terminate imminently. All work here needs to
// be synchronous.

// TODO: this code no longer works because stop() cannot be run synchronously. Maybe
// beforeExit event would be a decent middleground, or can run this in a signal handler.
// TODO #234: this code no longer works because stop() cannot be run synchronously.
// Remove this feature.
const profile = await stop();
const buffer = encodeSync(profile);
writeFileSync(`pprof-profile-${process.pid}.pb.gz`, buffer);
Expand Down