Skip to content

feat: leverage auth session and implement close method #2130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 10, 2024
Merged

feat: leverage auth session and implement close method #2130

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a2d897a
feat: leverage auth session and implement close method
ohmayr Sep 5, 2024
639c76b
address PR comments
ohmayr Sep 10, 2024
ccc1184
ignore type for exception
ohmayr Sep 10, 2024
38dcdd0
add comment for checking api-core supported version
ohmayr Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add comment for checking api-core supported version
  • Loading branch information
@ohmayr
ohmayr committed Sep 10, 2024
commit 38dcdd0219efde3337b55ee34874269e6b62b4bf
1 change: 1 addition & 0 deletions gapic/templates/%namespace/%name_%version/%sub/services/%service/client.py.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,6 +584,7 @@ class {{ service.client_name }}(metaclass={{ service.client_name }}Meta):
}
provided_unsupported_params = [name for name, value in unsupported_params.items() if value is not None]
if provided_unsupported_params:
{# TODO(https://github.com/googleapis/gapic-generator-python/issues/2137): Remove `type: ignore` once we add a version check for google-api-core. #}
raise core_exceptions.AsyncRestUnsupportedParameterError( # type: ignore
f"The following provided parameters are not supported for `transport=rest_asyncio`: {', '.join(provided_unsupported_params)}"
)
Expand Down
1 change: 1 addition & 0 deletions gapic/templates/tests/unit/gapic/%name_%version/%sub/test_macros.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1938,6 +1938,7 @@ def test_unsupported_parameter_rest_asyncio():
{# TODO(https://github.com/googleapis/google-auth-library-python/pull/1577): Update the version of google-auth once the linked PR is merged. #}
pytest.skip("google-auth > 2.x.x is required for async rest transport.")
options = client_options.ClientOptions(quota_project_id="octopus")
{# TODO(https://github.com/googleapis/gapic-generator-python/issues/2137): Remove `type: ignore` once we add a version check for google-api-core. #}
with pytest.raises(core_exceptions.AsyncRestUnsupportedParameterError, match="google.api_core.client_options.ClientOptions.quota_project_id") as exc: # type: ignore
client = {{ get_client(service, True) }}(
credentials={{get_credentials(True)}},
Expand Down