Switch Client to positional args #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
quartzmo
reviewed
May 30, 2019
gapic-generator/templates/default/service/client/method/docs/_request_normal.erb
Outdated
Show resolved
Hide resolved
quartzmo
approved these changes
May 30, 2019
Member
quartzmo
left a comment
quartzmo
left a comment
There was a problem hiding this comment.
LGTM. (Don't forget to change gem "google-gax", github: "blowmage/gax-ruby", branch: "2.0/client-methods-positional".)
quartzmo
reviewed
May 30, 2019
gapic-generator/templates/default/service/client/method/docs/_request_normal.erb
Show resolved
Hide resolved
quartzmo
approved these changes
May 30, 2019
Member
quartzmo
left a comment
quartzmo
left a comment
There was a problem hiding this comment.
Thanks for adding the documentation of the request attributes!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the Client RPC methods to use positional arguments instead of the mixed positional/named arguments. This is needed to work around Protobuf adding the
#to_hashmethod to the resource classes.This PR is dependent on googleapis/gax-ruby#208.