Skip to content

Conversation

@Assimilationstheorie
Copy link
Contributor

Remove Short-Opentags, because the option "--enable-short-tags" in php.ini are not unique configured...
Add simple HTML-Validation with "required"
Submit Button without value-att. are not cool!

Remove Short-Opentags, because the option "--enable-short-tags" in php.ini are not unique configured...
Add simple HTML-Validation with "required"
Submit Button without value-att. are not cool!
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jun 9, 2018
@Assimilationstheorie
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jun 9, 2018
</ul>

<?= pageFooter(); ?>
<?php echo pageFooter(); ?>

This comment was marked as spam.

@bshaffer
Copy link
Contributor

As mentioned in this comment, <?= is ok and we are keeping them.

I have never heard that a submit button without the value attribute is bad practice. Can you please point me to some resources saying so?

Adding the required tag is okay, but these samples are meant to be kept as simple as possible, so I am not really a fan. However, if you remove all the other stuff we can merge that.

@bshaffer
Copy link
Contributor

Closing so that we can roll these changes into #1456

@bshaffer bshaffer closed this Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants