Skip to content

Conversation

woofyman99
Copy link
Contributor

While the sample code works file from a local file. If you're reading from a URL, it's very inefficient. The sample code here is reading from a URL and is very inefficient.

https://developers.google.com/youtube/v3/code_samples/php#resumable_uploads

It looks like it was pulled directly from the sample code in GitHub

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Apr 27, 2015
@ianbarber
Copy link
Contributor

Any chance you could sign in the CLA - link in the bot comment? Understand if not, but we need it for any changes.

@woofyman99
Copy link
Contributor Author

No problem, done.

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels May 16, 2015
@ianbarber
Copy link
Contributor

Thanks!

ianbarber added a commit that referenced this pull request May 17, 2015
More efficient file upload from URL
@ianbarber ianbarber merged commit 523430f into googleapis:master May 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants