Skip to content

fix: mark all keyFile and keyFilePath options deprecated #8617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bshaffer merged 3 commits into from
Sep 29, 2025
Merged

fix: mark all keyFile and keyFilePath options deprecated #8617

bshaffer merged 3 commits into from
Sep 29, 2025

Conversation

@bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Sep 22, 2025

@bshaffer bshaffer requested review from a team as code owners September 22, 2025 21:22
@bshaffer bshaffer added the next release PRs to be included in the next release label Sep 22, 2025
@bshaffer bshaffer merged commit 5776416 into main Sep 29, 2025
37 checks passed
@bshaffer bshaffer deleted the warn-veneer-keyfile branch September 29, 2025 15:55
@release-please release-please bot mentioned this pull request Sep 29, 2025
Merged
purva9413 pushed a commit to purva9413/google-cloud-php that referenced this pull request Oct 2, 2025
@bshaffer @purvavasudeo
fix: mark all keyFile and keyFilePath options deprecated (googleapis#…
1d07444 
…8617)
This was referenced Oct 12, 2025
Closed
Merged
Merged
@jeromegamez
Copy link
Contributor

jeromegamez commented Oct 12, 2025 •
edited
Loading

I'm not sure, but is it possible that the @deprecated annotations for the config options break PHPStan?

Since upgrading to the latest version, PHPStan reports Call to deprecated method __construct() of class…, with or without using the deprecated options.

This is a PR in which I removed the keyFile option: https://github.com/kreait/firebase-php/pull/1026/files

jeromegamez added a commit to kreait/firebase-php that referenced this pull request Nov 1, 2025
@jeromegamez
Ignore deprecated method error
8537b3f 
The deprecation error has been introduced with the changes in
googleapis/google-cloud-php#8617.

Until/Unless googleapis/google-cloud-php#8689 or
something similar is implemented, we need to ignore the error here.
jeromegamez added a commit to kreait/firebase-php that referenced this pull request Nov 1, 2025
@jeromegamez
Ignore deprecated method error
a09bb87 
The deprecation error has been introduced with the changes in
googleapis/google-cloud-php#8617.

Until/Unless googleapis/google-cloud-php#8689 or
something similar is implemented, we need to ignore the error here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hectorhammett Hectorhammett Hectorhammett approved these changes

Assignees

No one assigned

Labels

next release PRs to be included in the next release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bshaffer @jeromegamez @Hectorhammett