Skip to content

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Sep 22, 2016

NOTE: Has #2392 as diffbase.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 22, 2016
@dhermes dhermes force-pushed the preparing-setup-for-subpackages branch from 6f5bf6a to 487ca1a Compare September 22, 2016 23:14
Copy link
Contributor

@daspecster daspecster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't seem to get this to work the way you expect?

>>> B = {'key': 'value'}
>>> c = ([], **B)
  File "<stdin>", line 1
    c = ([], **B)
              ^
SyntaxError: invalid syntax

@tseaver
Copy link
Contributor

tseaver commented Sep 23, 2016

@daspecster the ** only works when passed to a callable (the setup() function, in this case).

@dhermes
Copy link
Contributor Author

dhermes commented Sep 23, 2016

Any issues with this PR?

@daspecster If it didn't work, then Travis wouldn't be green 😉

@daspecster
Copy link
Contributor

daspecster commented Sep 23, 2016

@tseaver, oh right, deep down inside I knew that.

@dhermes yeah I realized that. I wasn't sure exactly how tox used setup.py or if it cared.

@dhermes dhermes merged commit 2f8b811 into googleapis:master Sep 23, 2016
@dhermes dhermes deleted the preparing-setup-for-subpackages branch September 23, 2016 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. packaging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants