Move vision code into a subpackage #2433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
theacodes
approved these changes
Sep 26, 2016
32 tasks
Done via: $ mkdir -p vision/google/cloud $ cp google/__init__.py vision/google/__init__.py $ git add vision/google/__init__.py $ cp google/cloud/__init__.py vision/google/cloud/__init__.py $ git add vision/google/cloud/__init__.py $ git mv google/cloud/vision vision/google/cloud/vision $ git mv unit_tests/vision vision/unit_tests
- Adding README, setup.py, MANIFEST.in, .coveragerc and tox.ini
- Adding google-cloud-vision as a dependency to the umbrella
package
- Adding the vision subdirectory into the list of packages
for verifying the docs
- Incorporating the vision subdirectory into the umbrella
coverage report
- Adding the vision only tox tests to the Travis config
- Adding {toxinidir}/../core as a dependency for the vision
tox config
Done mostly via: $ git grep -l 'unit_tests.vision._fixtures' | > xargs sed -i s/'unit_tests.vision._fixtures'/'unit_tests._fixtures'/g Then fixed up some indents after the fact.
dhermes
force-pushed
the
make-vision-subpackage
branch
from
09e3e3f to
b4d0998
Compare
Contributor
Author
|
Rebased after #2430. Green build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created via: https://gist.github.com/dhermes/e239691aa584bd56a5352e34aad27cf3
Third commit was done by hand to fix up fixture import problems.