feat: add Android 19 compatible FileDataStoreFactory implementation #1070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This is branched from the original implementation prior to switching to NIO for Windows compatibility.
chingor13
changed the title
chingor13
changed the title
elharo
reviewed
Jun 27, 2020
.../src/main/java/com/google/api/client/extensions/android/util/store/FileDataStoreFactory.java
Outdated
Show resolved
Hide resolved
File setReadable(), setWritable(), setExecutable() was added in API level 9, so we should not need to protect android users from missing methods as we support Android API 19+.
elharo
reviewed
Jun 29, 2020
.../src/main/java/com/google/api/client/extensions/android/util/store/FileDataStoreFactory.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/google/api/client/extensions/android/util/store/FileDataStoreFactory.java
Show resolved
Hide resolved
elharo
approved these changes
Jun 30, 2020
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jul 1, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [1.36.0](https://www.github.com/googleapis/google-http-java-client/compare/v1.35.0...v1.36.0) (2020-06-30) ### Features * add Android 19 compatible FileDataStoreFactory implementation ([#1070](https://www.github.com/googleapis/google-http-java-client/issues/1070)) ([1150acd](https://www.github.com/googleapis/google-http-java-client/commit/1150acd38aa3139eea4f2f718545c20d2493877e)) ### Bug Fixes * restore the thread's interrupted status after catching InterruptedException ([#1005](https://www.github.com/googleapis/google-http-java-client/issues/1005)) ([#1006](https://www.github.com/googleapis/google-http-java-client/issues/1006)) ([0a73a46](https://www.github.com/googleapis/google-http-java-client/commit/0a73a4628b6ec4420db6b9cdbcc68899f3807c5b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #906