Skip to content

Implement Closeable & Flushable in JsonGenerator and JsonParser #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 11, 2018
Merged

Implement Closeable & Flushable in JsonGenerator and JsonParser #540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e96701
fix #342 JsonGenerator and JsonParser should implement Closeable (and…
ajaaym Dec 10, 2018
d07aabe
remove flushable from JsonParser
ajaaym Dec 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion google-http-client/src/main/java/com/google/api/client/json/JsonGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
import com.google.api.client.util.Preconditions;
import com.google.api.client.util.Types;

import java.io.Closeable;
import java.io.Flushable;
import java.io.IOException;
import java.lang.reflect.Field;
import java.math.BigDecimal;
Expand All @@ -39,7 +41,7 @@
* @since 1.3
* @author Yaniv Inbar
*/
public abstract class JsonGenerator {
public abstract class JsonGenerator implements Closeable, Flushable {

/** Returns the JSON factory from which this generator was created. */
public abstract JsonFactory getFactory();
Expand Down
3 changes: 2 additions & 1 deletion google-http-client/src/main/java/com/google/api/client/json/JsonParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import com.google.api.client.util.Sets;
import com.google.api.client.util.Types;

import java.io.Closeable;
import java.io.IOException;
import java.lang.reflect.Field;
import java.lang.reflect.Modifier;
Expand Down Expand Up @@ -60,7 +61,7 @@
* @since 1.3
* @author Yaniv Inbar
*/
public abstract class JsonParser {
public abstract class JsonParser implements Closeable {

/**
* Maps a polymorphic {@link Class} to its {@link Field} with the {@link JsonPolymorphicTypeMap}
Expand Down