Skip to content

Update ApacheHttpTransport implementation #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 4, 2019
Merged

Update ApacheHttpTransport implementation #558

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c4680ae
Move apache httpclient dependency to apache adapter artifacts
chingor13 Jan 2, 2019
a8a6b42
Rewrite Apache adapter to use new APIs
chingor13 Jan 2, 2019
8d60892
Cleanup apache implementations
chingor13 Jan 3, 2019
11811d1
Fix tests
chingor13 Jan 3, 2019
ea65a51
Fix checkstyle
chingor13 Jan 3, 2019
ae05150
Fix dependencies - google-http-client does depend on commons-codec
chingor13 Jan 3, 2019
f9a48c9
Publish both apache adapters as google-http-client-apache with versio…
chingor13 Jan 3, 2019
273eddd
Fix dependency versions
chingor13 Jan 3, 2019
b4223fa
Remove ApacheHttpTransport.Builder for 2.0
chingor13 Jan 3, 2019
b107889
Allow `shutdown` to throw the IOException from closing the httpClient
chingor13 Jan 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Allow shutdown to throw the IOException from closing the httpClient
  • Loading branch information
@chingor13
chingor13 committed Jan 4, 2019
commit b107889883f323263e834f10d44bc8fcdad4b3c6
8 changes: 2 additions & 6 deletions ...tp-client-apache/src/main/java/com/google/api/client/http/apache/ApacheHttpTransport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,13 +185,9 @@ protected ApacheHttpRequest buildRequest(String method, String url) {
* @since 1.4
*/
@Override
public void shutdown() {
public void shutdown() throws IOException {
if (httpClient instanceof CloseableHttpClient) {
try {
((CloseableHttpClient) httpClient).close();
} catch (IOException e) {
// ignore
}
((CloseableHttpClient) httpClient).close();
}
}

Expand Down