Skip to content

372: Changed SingleThreadExecutor to FixedThreadPool(1). #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 13, 2019
Merged

372: Changed SingleThreadExecutor to FixedThreadPool(1). #588

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0679d65
372: Changed SingleThreadExecutor to FixedThreadPool(1).
Feb 12, 2019
ee74752
372: Use a deamon thread that the requests do not block jvm shutdown.
Feb 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions google-http-client/src/main/java/com/google/api/client/http/HttpRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import com.google.api.client.util.StreamingContent;
import com.google.api.client.util.StringUtils;

import com.google.common.util.concurrent.ThreadFactoryBuilder;
import io.opencensus.common.Scope;
import io.opencensus.contrib.http.util.HttpTraceAttributeConstants;
import io.opencensus.trace.AttributeValue;
Expand Down Expand Up @@ -1200,14 +1201,15 @@ public HttpResponse call() throws Exception {
/**
* {@link Beta} <br/>
* Executes this request asynchronously using {@link #executeAsync(Executor)} in a single separate
* thread using {@link Executors#newSingleThreadExecutor()}.
* thread using {@link Executors#newFixedThreadPool(1)}.
*
* @return A future for accessing the results of the asynchronous request.
* @since 1.13
*/
@Beta
public Future<HttpResponse> executeAsync() {
return executeAsync(Executors.newSingleThreadExecutor());
return executeAsync(
Executors.newFixedThreadPool(1, new ThreadFactoryBuilder().setDaemon(true).build()));
}

/**
Expand Down