depend directly on Apache httpclient #591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
added 2 commits
February 13, 2019 15:13
elharo
added
the
do not merge
elharo
changed the title
Contributor
Author
|
@sduskis Do you know how I can manually trigger the kokoro builds? |
elharo
added
the
kokoro:force-run
Contributor
Author
|
OK, looks there's a kokoro:force-run label |
elharo
removed
the
do not merge
elharo
commented
Feb 14, 2019
Contributor
Author
elharo
left a comment
elharo
left a comment
There was a problem hiding this comment.
PTAL @sduskis
All Kokoro jobs passed.
I think this PR is helpful for multiple reasons:
- Declares dependencies directly (i.e. like strict_java_deps) instead of relying on transitive dependencies
- Will resolve downstream linkage errors in dependents found in the dashboard
- Avoids pulling in a very old and out of date android artifact that was built and released by a third party because the AOSP did not want to ship a binary of this.
sduskis
approved these changes
Feb 14, 2019
clundin25
pushed a commit
to clundin25/google-http-java-client
that referenced
this pull request
Aug 11, 2022
…-sdk to v1.9.88 (googleapis#591) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | com.google.appengine:appengine-api-1.0-sdk | `1.9.86` -> `1.9.88` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/google-auth-library-java).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
](https://renovatebot.com){kind=link}
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depend directly on Apache httpclient instead of pulling it in transitively from weird android dependency.
Not sure why tests didn't run, but there's a local failure I'm investigating.
OK. tests passed locally. First failure was probably a DNS glitch caused by putting laptop to sleep in the middle.
@sduskis I'm still concerned that the kokoro jobs didn't fire here.