Skip to content

Fix: remove extraneous content encoding #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 15 commits into from
Closed

Fix: remove extraneous content encoding #650

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
ed237e3
Add failing test showing that encoding happens more than once
chingor13 May 24, 2019
331e250
Only encode the streaming content once.
chingor13 May 24, 2019
0604972
Remove assertion that the content is a HttpEncodingStreamingContent
chingor13 May 24, 2019
c4f29bc
Fix a bunch of typos (#640)
chingor13 May 26, 2019
1d4270d
Linting cleanup (#645)
chingor13 May 26, 2019
e64f72f
Remove deprecated google-http-client-jackson artifact. (#647)
chingor13 May 26, 2019
91cbfdb
Add Base64Test case for some base64 decoding edge cases (#644)
chingor13 May 26, 2019
1b18a6e
Add renovate.json (#651)
May 31, 2019
1a4a5cc
Update dependency com.fasterxml.jackson.core:jackson-core to v2.9.9 (…
renovate-bot May 31, 2019
b0d7245
Update dependency com.coveo:fmt-maven-plugin to v2.9 (#652)
renovate-bot May 31, 2019
13731cd
Update dependency com.google.code.gson:gson to v2.8.5 (#657)
renovate-bot May 31, 2019
78d4991
Add failing test showing that encoding happens more than once
chingor13 May 24, 2019
4fa6b09
Only encode the streaming content once.
chingor13 May 24, 2019
3d20d9a
Remove assertion that the content is a HttpEncodingStreamingContent
chingor13 May 24, 2019
a03bd43
Merge branch 'fix-double-encoding' of github.com:chingor13/google-htt…
chingor13 Jun 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove deprecated google-http-client-jackson artifact. (#647) 
* Remove deprecated google-http-client-jackson artifact.

Jackson 1.x has been unsupported for a long time. Users should be using
Jackson 2.x. the google-http-client-jackson artifact was deprecated in
1.28.0.

* Fix assembly references to jackson
  • Loading branch information
@chingor13
chingor13 authored May 26, 2019
commit e64f72f9deccc243312dbf621de728fabf208750
17 changes: 0 additions & 17 deletions google-http-client-assembly/assembly.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,6 @@
<outputDirectory>google-http-java-client/libs</outputDirectory>
<filtered>true</filtered>
</file>
<file>
<source>properties/google-http-client-jackson.jar.properties</source>
<destName>google-http-client-jackson-${project.version}.jar.properties</destName>
<outputDirectory>google-http-java-client/libs</outputDirectory>
<filtered>true</filtered>
</file>
<file>
<source>properties/google-http-client-jackson2.jar.properties</source>
<destName>google-http-client-jackson2-${project.version}.jar.properties</destName>
Expand Down Expand Up @@ -86,12 +80,6 @@
<outputDirectory>google-http-java-client/libs</outputDirectory>
<filtered>true</filtered>
</file>
<file>
<source>properties/jackson-core-asl.jar.properties</source>
<destName>jackson-core-asl-${project.jackson-core-asl.version}.jar.properties</destName>
<outputDirectory>google-http-java-client/libs</outputDirectory>
<filtered>true</filtered>
</file>
<file>
<source>properties/protobuf-java.jar.properties</source>
<destName>protobuf-java-${project.protobuf-java.version}.jar.properties</destName>
Expand Down Expand Up @@ -119,11 +107,6 @@
<destName>google-http-client-gson-dependencies.html</destName>
<outputDirectory>google-http-java-client/dependencies</outputDirectory>
</file>
<file>
<source>../google-http-client-jackson/target/site/dependencies.html</source>
<destName>google-http-client-jackson-dependencies.html</destName>
<outputDirectory>google-http-java-client/dependencies</outputDirectory>
</file>
<file>
<source>../google-http-client-jackson2/target/site/dependencies.html</source>
<destName>google-http-client-jackson2-dependencies.html</destName>
Expand Down
4 changes: 0 additions & 4 deletions google-http-client-assembly/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,6 @@
<groupId>com.google.http-client</groupId>
<artifactId>google-http-client-gson</artifactId>
</dependency>
<dependency>
<groupId>com.google.http-client</groupId>
<artifactId>google-http-client-jackson</artifactId>
</dependency>
<dependency>
<groupId>com.google.http-client</groupId>
<artifactId>google-http-client-jackson2</artifactId>
Expand Down
1 change: 0 additions & 1 deletion google-http-client-assembly/properties/google-http-client-jackson.jar.properties
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion google-http-client-assembly/properties/jackson-core-asl.jar.properties
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions google-http-client-bom/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,11 +90,6 @@
<artifactId>google-http-client-gson</artifactId>
<version>1.29.2-SNAPSHOT</version><!-- {x-version-update:google-http-client-gson:current} -->
</dependency>
<dependency>
<groupId>com.google.http-client</groupId>
<artifactId>google-http-client-jackson</artifactId>
<version>1.29.2-SNAPSHOT</version><!-- {x-version-update:google-http-client-jackson:current} -->
</dependency>
<dependency>
<groupId>com.google.http-client</groupId>
<artifactId>google-http-client-jackson2</artifactId>
Expand Down
110 changes: 0 additions & 110 deletions google-http-client-jackson/pom.xml
View file
Open in desktop

This file was deleted.

117 changes: 0 additions & 117 deletions ...-http-client-jackson/src/main/java/com/google/api/client/json/jackson/JacksonFactory.java
View file
Open in desktop

This file was deleted.

Loading