Skip to content

Add support for nanosecond precision when parsing rfc3339 strings #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 31, 2019
Merged

Add support for nanosecond precision when parsing rfc3339 strings #752

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
15e808d
support nanosecond precision when parsing rfc3339 strings
olavloite Jul 25, 2019
5f37367
removed hamcrest matchers
olavloite Jul 25, 2019
b53e75f
fix javadoc + change exception type
olavloite Jul 26, 2019
e8cf84a
assert parse directly instead of using a map
olavloite Jul 30, 2019
1c058b4
put expected and actual in correct order
olavloite Jul 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix javadoc + change exception type
  • Loading branch information
@olavloite
olavloite committed Jul 26, 2019
commit b53e75fee88a7d9cdb347c09a90af305a616dcfa
9 changes: 3 additions & 6 deletions google-http-client/src/main/java/com/google/api/client/util/DateTime.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,10 +263,7 @@ public int hashCode() {
* NumberFormatException}. Also, in accordance with the RFC3339 standard, any number of
* milliseconds digits is now allowed.
*
* <p>Any time information beyond millisecond precision will be truncated. Prior to version 1.30.2
* this method did not have a well-defined behavior of what would happen with any time information
* beyond millisecond precision. This could cause some values with more than millisecond precision
* to be rounded up instead of truncated.
* <p>Any time information beyond millisecond precision is truncated.
*
* <p>For the date-only case, the time zone is ignored and the hourOfDay, minute, second, and
* millisecond parameters are set to zero.
Expand All @@ -284,12 +281,12 @@ public static DateTime parseRfc3339(String str) throws NumberFormatException {
* Parses an RFC3339 timestamp to a pair of seconds and nanoseconds since Unix Epoch.
*
* @param str Date/time string in RFC3339 format
* @throws NumberFormatException if {@code str} doesn't match the RFC3339 standard format; an
* @throws IllegalArgumentException if {@code str} doesn't match the RFC3339 standard format; an
* exception is thrown if {@code str} doesn't match {@code RFC3339_REGEX} or if it contains a
* time zone shift but no time.
*/
public static SecondsAndNanos parseRfc3339ToSecondsAndNanos(String str)
throws NumberFormatException {
throws IllegalArgumentException {
return parseRfc3339WithNanoSeconds(str).toSecondsAndNanos();
}

Expand Down