Skip to content

Added two Unit Tests #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TheRealHaui wants to merge 3 commits into from
Closed

Added two Unit Tests #156

TheRealHaui wants to merge 3 commits into from

Conversation

@TheRealHaui
Copy link

@TheRealHaui TheRealHaui commented May 23, 2017

I've added two new Unit Tests and want to contribute them to the Google library.

@TheRealHaui
Copy link
Author

TheRealHaui commented May 25, 2017

@lesv
Could you review - and of course better - approve my without doubt small contribution?

@lesv
Copy link
Contributor

lesv commented May 31, 2017

The spacing is wrong - please see styleguide

@TheRealHaui
Copy link
Author

TheRealHaui commented Jun 1, 2017 •
edited
Loading

Thanks for your response!
Obviously used accidencially used the Spring source code formatter ...
Which rules I find partially wired too.
I'll use the Google Code formater from https://github.com/google/google-java-format and will commit again.

@TheRealHaui
Copy link
Author

TheRealHaui commented Jun 1, 2017

Here we go.
Reformatted the code, spacing changed entirely.

@lesv
Copy link
Contributor

lesv commented Jul 19, 2017

@garrettjonesgoogle Do we want this? I don't think it hurts, but I'm not totally convinced it helps either. Any opinion.

@garrettjonesgoogle
Copy link
Member

garrettjonesgoogle commented Jul 24, 2017

@shinfan could you check this for consistency with our existing stuff?

shinfan
shinfan requested changes Jul 24, 2017
View reviewed changes
google-oauth-client/src/test/java/com/google/api/client/auth/oauth/OAuthParametersTest.java
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2010 Google Inc.
* Copyright (c) 2010-2017 Google Inc.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

google-oauth-client/src/test/java/com/google/api/client/auth/oauth/OAuthParametersTest.java
}

public void testComputeNonceActuallyChangesNonce() {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

google-oauth-client/src/test/java/com/google/api/client/auth/oauth2/StoredCredentialTest.java

import org.junit.Test;

import static org.junit.Assert.*;

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

google-oauth-client/src/test/java/com/google/api/client/auth/oauth2/StoredCredentialTest.java

@Test
public void testGetRefreshTokenReturningNonEmptyString() throws Exception {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

...oauth-client/src/test/java/com/google/api/client/auth/openidconnect/IdTokenResponseTest.java
import org.junit.Test;

import static junit.framework.Assert.assertNotNull;
import static org.junit.Assert.*;

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@TheRealHaui TheRealHaui mentioned this pull request Jul 25, 2017
Closed
@TheRealHaui
Copy link
Author

TheRealHaui commented Jul 25, 2017

Unfortunately, I have deleted my fork meanwhile ...
Therefore I cannot update this pull request.
I close this pull request and reference from the new one that contains all requested changes.
Sorry for the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shinfan shinfan shinfan requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TheRealHaui @lesv @garrettjonesgoogle @shinfan