Skip to content

Conversation

@emilesalem
Copy link

we need to access the id token in order to call google cloud endpoints

i.e

GoogleCredential credential = GoogleCredential.getApplicationDefault(); 
credential = credential.createScoped(...); 
credential.refreshToken(); 
credential.getIdToken();

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@emilesalem
Copy link
Author

I signed the CLA

@googlebot
Copy link

CLAs look good, thanks!

@JustinBeckwith JustinBeckwith requested a review from a team June 6, 2018 00:25
@JustinBeckwith
Copy link
Contributor

gentle ping @google/yoshi-java

@chingor13 chingor13 self-assigned this Jul 11, 2018
@chingor13
Copy link
Contributor

Sorry for the delay in getting to this.

I don't think adding id_token parsing to TokenResponse is the correct approach. id_token parsing is already provided by IdTokenResponse and GoogleTokenResponse from google-api-client. The TokenResponse class is a generic implementation for OAuth2 and does not need to include id_token.

I'm also unclear on your usage of this with application default credentials as the id_token is part of the OpenID Connect protocol on top of 3-legged OAuth 2.0.

For a workaround you can use GoogleAuthorizationCodeFlow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants