Skip to content

fix: capture and throw on non-existent files #1969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 25, 2022
Merged

fix: capture and throw on non-existent files #1969

merged 2 commits into from
May 25, 2022

Conversation

@danielbankhead
Copy link
Contributor

@danielbankhead danielbankhead commented May 25, 2022

Fixes #1968 🦕

@danielbankhead danielbankhead requested review from a team as code owners May 25, 2022 20:29
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/nodejs-storage API. labels May 25, 2022
@d-goog
fix: use event handler instead of pipeline
d3fa0c5 
- TS doesn't support the pipeline `value` return in the callback yet...
@danielbankhead danielbankhead mentioned this pull request May 25, 2022
Closed
@sethvargo
Copy link

sethvargo commented May 25, 2022

Thanks!

@danielbankhead danielbankhead merged commit 52d81c0 into main May 25, 2022
@danielbankhead danielbankhead deleted the fix-unhandled-upload-read-rejection branch May 25, 2022 20:53
@release-please release-please bot mentioned this pull request May 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ddelgrosso1 ddelgrosso1 ddelgrosso1 approved these changes

+1 more reviewer

@sethvargo sethvargo sethvargo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/nodejs-storage API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

v6.0.0 throws exceptions off main thread during upload

5 participants

@danielbankhead @sethvargo @ddelgrosso1 @d-goog