Skip to content

Conversation

ohmayr
Copy link
Contributor

@ohmayr ohmayr commented Sep 9, 2024

This change is adding include-hidden-files to the upload-artifact step. The upload-artifact excludes hidden files by default here so that .coverage-* files would be excluded to be uploaded.

The unit tests coverage is failing in the github workflow.
See related issue: googleapis/synthtool#2008
See related change: googleapis/synthtool@e6f91eb#diff-0dbf2b78c50a77be560a8578d2ce0ffa60ab27416743f7a4814135f23414588d

@ohmayr ohmayr requested review from a team as code owners September 9, 2024 20:04
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Sep 9, 2024
@ohmayr ohmayr changed the title fix: coverage for unit tests chore: update unittest workflow template Sep 9, 2024
Copy link
Contributor

@vchudnov-g vchudnov-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add to PR description how this affects us? Specifically, that the .coverage* files were getting excluded.

@ohmayr ohmayr merged commit 082bce2 into main Sep 10, 2024
33 checks passed
@ohmayr ohmayr deleted the fix/coverage-for-unit-tests branch September 10, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants