feat: support for async bidi streaming apis #836

chandra-siri · 2025-08-14T06:43:22Z

feat: support for async bidi streaming apis

Further details can be found here

Fixes #834

python versions <= 3.10 dont support `async with asyncio.timeout`

provide support for the same.

google/api_core/bidi_async.py

google/api_core/bidi.py

google/api_core/bidi_async.py

google/api_core/bidi_base.py

google/api_core/bidi_async.py

…into feat/834-bidi-async-support

these files will be removed once googleapis/python-api-core#836 gets submitted

* Add async bidiRpc files in python-storage these files will be removed once googleapis/python-api-core#836 gets submitted * fix import path for bidi_base

tests/asyncio/test_bidi_async.py

google/api_core/bidi_async.py

vchudnov-g

Looks good. I have some small comments, and a bunch of nits. I'll TAL at the test next week.

google/api_core/bidi_async.py

vchudnov-g · 2025-09-25T20:16:20Z

google/api_core/bidi_async.py

+
+        request_generator.call = call
+
+        if hasattr(call, "_wrapped"):  # pragma: NO COVER


Was the TODO in the original file addressed?

not sure, is there any issue number ? or internal bugId ?

It doesn't have an issue. You could create one, but at least copy the text: # TODO: api_core should expose the future interface for wrapped callables as well.

No issue number (you could create one), but let's at least include the text: # TODO: api_core should expose the future interface for wrapped callables as well.

google/api_core/bidi.py

google/api_core/bidi_async.py

tests/asyncio/test_bidi_async.py

vchudnov-g · 2025-09-25T21:00:00Z

Adding @daniel-sanche for visibility.

@ohmayr , do you have any remaining concerns with the code?

…into feat/834-bidi-async-support

chandra-siri · 2025-10-01T13:50:04Z

Looks good. I have some small comments, and a bunch of nits. I'll TAL at the test next week.

@vchudnov-g Addressed your comments. PTAL

vchudnov-g

Looks good. We're almost there. Just some minor comments, and I want to ping @daniel-sanche again in case he has any comments.

google/api_core/bidi.py

vchudnov-g · 2025-10-03T23:07:58Z

google/api_core/bidi_async.py

+
+        request_generator.call = call
+
+        if hasattr(call, "_wrapped"):  # pragma: NO COVER


It doesn't have an issue. You could create one, but at least copy the text: # TODO: api_core should expose the future interface for wrapped callables as well.

vchudnov-g · 2025-10-03T23:15:41Z

google/api_core/bidi_async.py

+
+        request_generator.call = call
+
+        if hasattr(call, "_wrapped"):  # pragma: NO COVER


No issue number (you could create one), but let's at least include the text: # TODO: api_core should expose the future interface for wrapped callables as well.

google/api_core/bidi_base.py

tests/asyncio/test_bidi_async.py

daniel-sanche

I left a few small comments, but nothing that needs to be blocking

Type checking would improve this a lot though, to help us be sure there are no gaps in the shared sync/async logic

google/api_core/bidi_base.py

google/api_core/bidi_async.py

chandra-siri · 2025-10-08T16:09:59Z

I left a few small comments, but nothing that needs to be blocking

Type checking would improve this a lot though, to help us be sure there are no gaps in the shared sync/async logic

Hi @daniel-sanche , I've addressed your comments, left one open. Feel free to resolve it sounds good to you.

google/api_core/bidi_async.py

daniel-sanche

still a few nits open, but LGTM

chandra-siri · 2025-10-09T09:26:48Z

still a few nits open, but LGTM

Addressed them.

chandra-siri · 2025-10-09T09:27:45Z

Looks good. We're almost there. Just some minor comments, and I want to ping @daniel-sanche again in case he has any comments.

Hi @vchudnov-g Addressed yours and Daniel's comments/suggestions. PTAL

vchudnov-g

Looks great. I left some very minor follow-up comments—nothing blocking.

Thanks for your dedication to this PR and patience working with us on understanding it and making it really solid!

chandra-siri · 2025-10-11T09:20:01Z

Looks great. I left some very minor follow-up comments—nothing blocking.

Addressed them.

Thanks for your dedication to this PR and patience working with us on understanding it and making it really solid!

Thanks @vchudnov-g

1 more help - can you please merge the PR ? (looks like I don't have the sufficient permissions)

feat: support for async bidi streaming apis

d751f63

product-auto-label bot added the size: l Pull request size is large. label Aug 14, 2025

chandra-siri added 11 commits August 14, 2025 06:57

fix linting

fdcd903

Add bidiBase, refactor bidiRpc and add AsyncBidi

5835178

remove changes from noxfile

df8fba5

use queue.get() instead of queue.get_nowait()

19cf273

use asyncio.wait_for instead of asyncio.timeout

5b6d287

python versions <= 3.10 dont support `async with asyncio.timeout`

aiter() and anext() are not defined in python<=3.9

2599f96

provide support for the same.

remove support for python 3.7 and below

9c1a621

fix mypy errors

cc19089

fix typo, version -> version_info

a86a9b1

AsyncMock not present in python3.7

5464dc5

update doc strings

e96a409

chandra-siri marked this pull request as ready for review August 30, 2025 17:13

chandra-siri requested review from a team as code owners August 30, 2025 17:13

blunderbuss-gcf bot assigned vchudnov-g Aug 30, 2025

chandra-siri added 3 commits September 1, 2025 11:39

use pytest.approx to round of floating point errors.

52686b8

add tolerance

d01421b

add test_open_error_call_error unit test

98eae06

ohmayr reviewed Sep 4, 2025

View reviewed changes

chandra-siri added 3 commits September 8, 2025 18:17

Merge branch 'main' of https://github.com/googleapis/python-api-core …

af2121c

…into feat/834-bidi-async-support

minor changes based on PR comments

5a7550f

formatting fixes

c486c49

chandra-siri requested a review from ohmayr September 8, 2025 19:25

remove changes from test_method.py

14342b1

chandra-siri added a commit to chandra-siri/python-storage that referenced this pull request Sep 17, 2025

Add async bidiRpc files in python-storage

32168a6

these files will be removed once googleapis/python-api-core#836 gets submitted

chandra-siri mentioned this pull request Sep 17, 2025

feat: Add async bidiRpc files in python-storage googleapis/python-storage#1545

Merged

fix typos in doc string and error msg

6fabb1f

ohmayr reviewed Sep 24, 2025

View reviewed changes

tests/asyncio/test_bidi_async.py Outdated Show resolved Hide resolved

google/api_core/bidi_async.py Outdated Show resolved Hide resolved

vchudnov-g reviewed Sep 25, 2025

View reviewed changes

chandra-siri added 2 commits October 1, 2025 13:45

address review comments. mostly fix doc-strings

b963922

Merge branch 'main' of https://github.com/googleapis/python-api-core …

470aeb4

…into feat/834-bidi-async-support

remove unused variable to fix lint

7475d99

chandra-siri requested review from ohmayr and vchudnov-g October 1, 2025 13:54

vchudnov-g reviewed Oct 4, 2025

View reviewed changes

daniel-sanche reviewed Oct 6, 2025

View reviewed changes

google/api_core/bidi_base.py Outdated Show resolved Hide resolved

google/api_core/bidi_base.py Show resolved Hide resolved

google/api_core/bidi_base.py Outdated Show resolved Hide resolved

google/api_core/bidi_base.py Show resolved Hide resolved

daniel-sanche reviewed Oct 6, 2025

View reviewed changes

google/api_core/bidi_async.py Show resolved Hide resolved

fix & imporove docstrings & comments. Reduce test timeout duration

8bf8396

write floating point numbers are per pylint

827d3c1

chandra-siri requested review from daniel-sanche and vchudnov-g October 8, 2025 16:16

daniel-sanche reviewed Oct 8, 2025

View reviewed changes

google/api_core/bidi_async.py Outdated Show resolved Hide resolved

daniel-sanche previously approved these changes Oct 8, 2025

View reviewed changes

correct exception type in _async files

69f061b

chandra-siri dismissed daniel-sanche’s stale review via 69f061b October 9, 2025 09:20

chandra-siri added 3 commits October 9, 2025 10:18

move comments from class level to method level

d528dd0

add .close() in Example code

4ee9826

throw better error msg when stream is not opened

5f3e5ba

daniel-sanche approved these changes Oct 9, 2025

View reviewed changes

vchudnov-g approved these changes Oct 10, 2025

View reviewed changes

Merge branch 'main' into feat/834-bidi-async-support

82cea4f


		request_generator.call = call

		if hasattr(call, "_wrapped"): # pragma: NO COVER

feat: support for async bidi streaming apis #836

Are you sure you want to change the base?

feat: support for async bidi streaming apis #836

Uh oh!

Conversation

chandra-siri commented Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vchudnov-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vchudnov-g Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

chandra-siri Oct 1, 2025

Choose a reason for hiding this comment

Uh oh!

vchudnov-g Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

vchudnov-g Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vchudnov-g commented Sep 25, 2025

Uh oh!

chandra-siri commented Oct 1, 2025

Uh oh!

vchudnov-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vchudnov-g Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

vchudnov-g Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

daniel-sanche left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chandra-siri commented Oct 8, 2025

Uh oh!

Uh oh!

daniel-sanche left a comment

Choose a reason for hiding this comment

Uh oh!

chandra-siri commented Oct 9, 2025

Uh oh!

chandra-siri commented Aug 14, 2025 •

edited

Loading

daniel-sanche left a comment •

edited

Loading

chandra-siri commented Oct 11, 2025 •

edited

Loading