Skip to content

chore: fix the test cover workflow #948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 4, 2024
Merged

chore: fix the test cover workflow #948

merged 6 commits into from
Sep 4, 2024

Conversation

@chelsea-lin
Copy link
Contributor

@chelsea-lin chelsea-lin commented Sep 3, 2024 •
edited
Loading

This change is fixing a regression of the cover workflow. The upload-artifact excludes hidden files by default here.

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Sep 3, 2024
@chelsea-lin chelsea-lin marked this pull request as ready for review September 4, 2024 00:17
@chelsea-lin chelsea-lin requested review from a team as code owners September 4, 2024 00:17
@chelsea-lin chelsea-lin requested a review from shobsi September 4, 2024 00:17
@tswast tswast enabled auto-merge (squash) September 4, 2024 00:29
@chelsea-lin chelsea-lin added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 4, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 4, 2024
@product-auto-label product-auto-label bot added size: u Pull request is empty. and removed size: xs Pull request size is extra small. labels Sep 4, 2024
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: u Pull request is empty. labels Sep 4, 2024
@chelsea-lin
Copy link
Contributor Author

chelsea-lin commented Sep 4, 2024

The change gets updated by owlbot so the change should be fixed here: googleapis/synthtool#2008
This change excludes the unittest.yml from the owlbot so that we can unblock BF workflow earlier if the synthtool fixing takes a longer time.

@chelsea-lin chelsea-lin disabled auto-merge September 4, 2024 05:01
@chelsea-lin chelsea-lin enabled auto-merge (squash) September 4, 2024 05:28
@chelsea-lin chelsea-lin merged commit 1291110 into main Sep 4, 2024
@chelsea-lin chelsea-lin deleted the main_chelsealin_fixcover branch September 4, 2024 05:55
sycai added a commit to googleapis/python-bigquery-magics that referenced this pull request Sep 11, 2024
@sycai
Fix test cover workflow. Ref: googleapis/python-bigquery-dataframes#948
078a319
sycai added a commit to googleapis/python-bigquery-magics that referenced this pull request Sep 13, 2024
@sycai
refactor: use dataclass for Context to reduce boilerplate (#53)
aa4b655 
* refactor: use dataclass for Context to reduce boilerplate

* Fix test cover workflow. Ref: googleapis/python-bigquery-dataframes#948

* Fix field name

* fix docstring indentation
@chelsea-lin chelsea-lin mentioned this pull request Sep 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswast tswast tswast approved these changes

@GarrettWu GarrettWu GarrettWu approved these changes

@shobsi shobsi shobsi approved these changes

@TrevorBergeron TrevorBergeron Awaiting requested review from TrevorBergeron TrevorBergeron is a code owner automatically assigned from googleapis/api-bigquery-dataframe

Assignees

@rey-esp rey-esp

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@chelsea-lin @tswast @GarrettWu @shobsi @rey-esp