Skip to content

refactor: use dataclass for Context to reduce boilerplate #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 13, 2024
Merged

refactor: use dataclass for Context to reduce boilerplate #53

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
500d91b
refactor: use dataclass for Context to reduce boilerplate
sycai Sep 11, 2024
078a319
Fix test cover workflow. Ref: https://github.com/googleapis/python-bi…
sycai Sep 11, 2024
073463e
Fix field name
sycai Sep 11, 2024
cd4e407
fix docstring indentation
sycai Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix field name
  • Loading branch information
@sycai
sycai committed Sep 11, 2024
commit 073463e621dce63f0b4d325ff26a97c001d48e9e
3 changes: 1 addition & 2 deletions bigquery_magics/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,7 @@ class Context(object):

_credentials = None
_project = None

connection = None
_connection = None

default_query_job_config = bigquery.QueryJobConfig()
"""google.cloud.bigquery.job.QueryJobConfig: Default job
Expand Down