Skip to content

fix: configure keepAlive time for gRPC TCP connections #1448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rahul2393 merged 9 commits into from
Oct 28, 2025
Merged

fix: configure keepAlive time for gRPC TCP connections #1448

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6327330
fix: configure keepAlive time for gRPC TCP connections
rahul2393 Oct 27, 2025
5c84c73
fix tests
rahul2393 Oct 27, 2025
4f0e6f5
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Oct 27, 2025
8d070a1
fix tests
rahul2393 Oct 27, 2025
e909d22
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Oct 27, 2025
94d8f2a
fix flaky abort retry error
rahul2393 Oct 28, 2025
8d5866b
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Oct 28, 2025
5cf7e16
update owlbot to persist the changes
rahul2393 Oct 28, 2025
a09adb5
fix owlbot
rahul2393 Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix tests
  • Loading branch information
@rahul2393
rahul2393 committed Oct 27, 2025
commit 8d070a16b781c87f5dc4c354b527385e87b99f60
25 changes: 15 additions & 10 deletions tests/unit/gapic/spanner_admin_database_v1/test_database_admin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1136,6 +1136,7 @@ def test_database_admin_client_create_channel_credentials_file(
options=[
("grpc.max_send_message_length", -1),
("grpc.max_receive_message_length", -1),
("grpc.keepalive_time_ms", 120000),
],
)

Expand Down Expand Up @@ -23315,6 +23316,7 @@ def test_database_admin_transport_create_channel(transport_class, grpc_helpers):
options=[
("grpc.max_send_message_length", -1),
("grpc.max_receive_message_length", -1),
("grpc.keepalive_time_ms", 120000),
],
)

Expand Down Expand Up @@ -23347,6 +23349,7 @@ def test_database_admin_grpc_transport_client_cert_source_for_mtls(transport_cla
options=[
("grpc.max_send_message_length", -1),
("grpc.max_receive_message_length", -1),
("grpc.keepalive_time_ms", 120000),
],
)

Expand Down Expand Up @@ -23590,11 +23593,12 @@ def test_database_admin_transport_channel_mtls_with_client_cert_source(transport
scopes=None,
ssl_credentials=mock_ssl_cred,
quota_project_id=None,
options=[
("grpc.max_send_message_length", -1),
("grpc.max_receive_message_length", -1),
],
)
options=[
("grpc.max_send_message_length", -1),
("grpc.max_receive_message_length", -1),
("grpc.keepalive_time_ms", 120000),
],
)
assert transport.grpc_channel == mock_grpc_channel
assert transport._ssl_channel_credentials == mock_ssl_cred

Expand Down Expand Up @@ -23637,11 +23641,12 @@ def test_database_admin_transport_channel_mtls_with_adc(transport_class):
scopes=None,
ssl_credentials=mock_ssl_cred,
quota_project_id=None,
options=[
("grpc.max_send_message_length", -1),
("grpc.max_receive_message_length", -1),
],
)
options=[
("grpc.max_send_message_length", -1),
("grpc.max_receive_message_length", -1),
("grpc.keepalive_time_ms", 120000),
],
)
assert transport.grpc_channel == mock_grpc_channel


Expand Down
5 changes: 5 additions & 0 deletions tests/unit/gapic/spanner_admin_instance_v1/test_instance_admin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1125,6 +1125,7 @@ def test_instance_admin_client_create_channel_credentials_file(
options=[
("grpc.max_send_message_length", -1),
("grpc.max_receive_message_length", -1),
("grpc.keepalive_time_ms", 120000),
],
)

Expand Down Expand Up @@ -18621,6 +18622,7 @@ def test_instance_admin_transport_create_channel(transport_class, grpc_helpers):
options=[
("grpc.max_send_message_length", -1),
("grpc.max_receive_message_length", -1),
("grpc.keepalive_time_ms", 120000),
],
)

Expand Down Expand Up @@ -18653,6 +18655,7 @@ def test_instance_admin_grpc_transport_client_cert_source_for_mtls(transport_cla
options=[
("grpc.max_send_message_length", -1),
("grpc.max_receive_message_length", -1),
("grpc.keepalive_time_ms", 120000),
],
)

Expand Down Expand Up @@ -18881,6 +18884,7 @@ def test_instance_admin_transport_channel_mtls_with_client_cert_source(transport
options=[
("grpc.max_send_message_length", -1),
("grpc.max_receive_message_length", -1),
("grpc.keepalive_time_ms", 120000),
],
)
assert transport.grpc_channel == mock_grpc_channel
Expand Down Expand Up @@ -18928,6 +18932,7 @@ def test_instance_admin_transport_channel_mtls_with_adc(transport_class):
options=[
("grpc.max_send_message_length", -1),
("grpc.max_receive_message_length", -1),
("grpc.keepalive_time_ms", 120000),
],
)
assert transport.grpc_channel == mock_grpc_channel
Expand Down
Loading