Skip to content

fix(gax): prevent truncation/overflow when converting time values #3095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 29, 2024
Merged

fix(gax): prevent truncation/overflow when converting time values #3095

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0fb8160
fix(gax): prevent truncation/overflow when converting time values
diegomarquezp Aug 12, 2024
329c467
Update gax-java/gax/src/test/java/com/google/api/gax/util/TimeConvers…
diegomarquezp Aug 13, 2024
5014c4b
Update gax-java/gax/src/test/java/com/google/api/gax/util/TimeConvers…
diegomarquezp Aug 13, 2024
86d5855
add max possible nano quantity to max possible seconds quantity in du…
diegomarquezp Aug 15, 2024
cfa3b06
Merge branch 'fix-time-conversion-precision' of https://github.com/go…
diegomarquezp Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions gax-java/gax/src/test/java/com/google/api/gax/util/TimeConversionUtilsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ public class TimeConversionUtilsTest {

// 0.999999999 seconds (1 second - 1 nano) - we need to subtract the nano or the Duration would
// overflow otherwise
final long MAX_DURATION_NANOS = 1 * 1000 * 1000 * 1000 - 1;
final long MAX_DURATION_NANOS =
1 * 1000 /*=1 micro*/ * 1000 /*=1 milli*/ * 1000 /*=1 second*/ - 1;

// Arbitrary durations/instants to confirm conversion works as expected
final org.threeten.bp.Duration ttDuration = org.threeten.bp.Duration.ofMillis(123);
Expand Down Expand Up @@ -96,8 +97,7 @@ void testToJavaTimeInstant_bigInput_doesNotOverflow() {
@Test
void testToThreeteenDuration_bigInput_doesNotOverflow() {
// we use the max long value for the seconds part and an arbitrary int for the nanos part, so we
// can confirm
// that both components are preserved
// can confirm that both components are preserved
java.time.Duration jtDuration =
java.time.Duration.ofSeconds(Long.MAX_VALUE, MAX_DURATION_NANOS);
org.threeten.bp.Duration ttDuration = TimeConversionUtils.toThreetenDuration(jtDuration);
Expand All @@ -108,8 +108,7 @@ void testToThreeteenDuration_bigInput_doesNotOverflow() {
@Test
void testToJavaTimeDuration_bigInput_doesNotOverflow() {
// we use the max long value for the seconds part and an arbitrary int for the nanos part, so we
// can confirm
// that both components are preserved
// can confirm that both components are preserved
org.threeten.bp.Duration ttDuration =
org.threeten.bp.Duration.ofSeconds(Long.MAX_VALUE, MAX_DURATION_NANOS);
java.time.Duration jtDuration = TimeConversionUtils.toJavaTimeDuration(ttDuration);
Expand Down