Skip to content

feat: add toString to futures returned by operations #3140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 30, 2024
Merged

feat: add toString to futures returned by operations #3140

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ffa3683
feat: add toString to futures returned by operations
igorbernstein2 Aug 29, 2024
fee03b1
toString for retrying
igorbernstein2 Aug 29, 2024
5a92d26
format
igorbernstein2 Aug 29, 2024
4c04043
Merge branch 'main' into future-tostring
igorbernstein2 Aug 29, 2024
55f57c5
use junit5
igorbernstein2 Aug 29, 2024
13094ba
Merge remote-tracking branch 'origin/main' into future-tostring
igorbernstein2 Aug 29, 2024
e5d23d4
Merge remote-tracking branch 'igor/future-tostring' into future-tostring
igorbernstein2 Aug 29, 2024
2f05c42
junit5 codestyle
igorbernstein2 Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
toString for retrying
  • Loading branch information
@igorbernstein2
igorbernstein2 committed Aug 29, 2024
commit fee03b13827383f97e1517f5da0255f643c2dcbd
12 changes: 12 additions & 0 deletions gax-java/gax/src/main/java/com/google/api/gax/retrying/BasicRetryingFuture.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
import com.google.api.core.ApiFuture;
import com.google.api.core.ApiFutures;
import com.google.api.gax.tracing.ApiTracer;
import com.google.common.base.MoreObjects;
import com.google.common.util.concurrent.AbstractFuture;
import com.google.common.util.concurrent.MoreExecutors;
import java.util.concurrent.Callable;
Expand Down Expand Up @@ -265,6 +266,17 @@ private void setAttemptResult(Throwable throwable, ResponseT response, boolean s
}
}

@Override
public String toString() {
return MoreObjects.toStringHelper(this.getClass())
.add("super", pendingToString())
.add("latestCompletedAttemptResult", this.latestCompletedAttemptResult)
.add("attemptResult", this.attemptResult)
.add("attemptSettings", this.attemptSettings)
.toString();

}

private class CompletionListener implements Runnable {
@Override
public void run() {
Expand Down