Skip to content

feat: add Batcher#close(timeout) and Batcher#cancelOutstanding #3141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Sep 9, 2024
Merged

feat: add Batcher#close(timeout) and Batcher#cancelOutstanding #3141

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
c889736
There have been reports of batcher.close() hanging every once in awhi…
igorbernstein2 Aug 29, 2024
323e5a1
format
igorbernstein2 Aug 29, 2024
17f4890
add tests
igorbernstein2 Aug 29, 2024
6843a64
Merge branch 'main' into batcher-debug
igorbernstein2 Aug 29, 2024
4b35a0a
ignore clirr on INternalExtensionOnly interface
igorbernstein2 Aug 30, 2024
7760375
Update gax-java/gax/clirr-ignored-differences.xml
igorbernstein2 Aug 31, 2024
5ebf4ae
Merge branch 'main' into batcher-debug
igorbernstein2 Aug 31, 2024
9be3743
address feedback
igorbernstein2 Sep 9, 2024
a410422
Merge remote-tracking branch 'igor/batcher-debug' into batcher-debug
igorbernstein2 Sep 9, 2024
dc74664
Merge branch 'main' into batcher-debug
igorbernstein2 Sep 9, 2024
f2fdac1
missing rename
igorbernstein2 Sep 9, 2024
821d41c
Merge remote-tracking branch 'igor/batcher-debug' into batcher-debug
igorbernstein2 Sep 9, 2024
b20824f
make responseFuture volatile because it can be written by the autoflu…
igorbernstein2 Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
make responseFuture volatile because it can be written by the autoflu… 
…sh thread and read by the user thread during cancel()
  • Loading branch information
@igorbernstein2
igorbernstein2 committed Sep 9, 2024
commit b20824fbd9c000e92ea6db45e94dc9eb38a6f946
2 changes: 1 addition & 1 deletion gax-java/gax/src/main/java/com/google/api/gax/batching/BatcherImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,7 +476,7 @@ private static class Batch<ElementT, ElementResultT, RequestT, ResponseT> {
private long totalThrottledTimeMs = 0;
private BatchResource resource;

private ApiFuture<ResponseT> responseFuture;
private volatile ApiFuture<ResponseT> responseFuture;

private Batch(
RequestT prototype,
Expand Down