core(gather-runner): always reset scroll position #8625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
brendankenny
left a comment
brendankenny
left a comment
There was a problem hiding this comment.
seems like a good idea? I don't see strong downsides. Is scrollTo a no-op if scrolling to where the page already is?
|
|
||
| // Some gatherers scroll the page which can cause unexpected results for other gatherers. | ||
| // We reset the scroll position in between each gatherer. | ||
| const scrollPosition = pageLoadError ? null : await driver.getScrollPosition(); |
Contributor
There was a problem hiding this comment.
pageLoadError control flow is seriously the worst :S
Co-Authored-By: patrickhulce <[email protected]>
Member
|
let's land this after we ship 5.0.0 |
Collaborator
Author
It is now post-5.0.0, reviews welcome :) |
paulirish
approved these changes
May 25, 2019
Contributor
|
yeah, no, bad merge, bad :) |
brendankenny
added a commit
that referenced
this pull request
May 25, 2019
This reverts commit 6bc4f89.
brendankenny
added a commit
that referenced
this pull request
May 25, 2019
patrickhulce
added a commit
that referenced
this pull request
May 25, 2019
paulirish
pushed a commit
that referenced
this pull request
May 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Came up a few times now, but we should give gatherers a consistent view of the page. This PR saves the scroll position of the page after we're done loading and scrolls back to it after every gatherer.
Related Issues/PRs
#7778 (comment)