core(runner): fix missing timing properties in the browser #9072
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PerformanceEntries in Lightrider (and the extension) had no names and no entryTypes. This manifested as a 0
timing.totalin the API as well.@brendankenny found that browser PerformanceEntry objects do not spread, but in Node they do b/c of the marky lib. So, simple fix to explicitly call out the
nameandentryTypefields when parsing the entries. This will also populate the missinglh:runner:runentry to fill intiming.total.Related Issues/PRs
fixes: #8638