clients(proto): don't filter channel from configSettings #9554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
approved these changes
Aug 14, 2019
Collaborator
patrickhulce
left a comment
patrickhulce
left a comment
There was a problem hiding this comment.
LGTM
I don't suppose there's anything else missing while we're in here? everything else looks OK to me
Member
Author
I'm doing integration testing now with a fine toothed comb. So...I don't know yet! But we'll see! |
brendankenny
changed the title
brendankenny
approved these changes
Aug 15, 2019
Contributor
brendankenny
left a comment
brendankenny
left a comment
There was a problem hiding this comment.
LGTM2
I'm doing integration testing now with a fine toothed comb. So...I don't know yet! But we'll see!
just to be clear, the above makes it sound like you'd open up another PR if you find more things, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
channelnever made the roundtrip! And 'lr' got lost in the process.