core(gather-runner): only fail for mainRecord interstitials #9576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
approved these changes
Aug 19, 2019
Member
paulirish
left a comment
paulirish
left a comment
There was a problem hiding this comment.
good stuff.
got some unit test failures to resolve. otherwise lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Several folks have reported that it's unexpected/undesirable for LH to fail when iframes fail with an interstitial, this loosens our logic to only fail when the mainRecord fails with an interstitial. Our usual caveats about client-side/JS redirects not working will now apply here too.
Related Issues/PRs
fixes #9562