misc(build): include locale files in devtools roll #9639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
reviewed
Sep 4, 2019
| lh_locales_dir="lighthouse-core/lib/i18n/locales/" | ||
| fe_locales_dir="$frontend_dir/audits_worker/lighthouse/locales/" | ||
|
|
||
| cp -r "$lh_locales_dir" "$fe_locales_dir" |
Collaborator
There was a problem hiding this comment.
this copies the folder into the destination if the already exists.
just do the glob cp, like above? cp -r ./from/* ./to/. could even drop the -r.
connorjclark
reviewed
Sep 5, 2019
| fe_locales_dir="$frontend_dir/audits_worker/lighthouse/locales" | ||
|
|
||
| cp -r "$lh_locales_dir" "$fe_locales_dir" | ||
| find $lh_locales_dir -name '*.json' ! -name '*.ctc.json' -exec cp {} "$fe_locales_dir" \; |
Collaborator
There was a problem hiding this comment.
fine as long as the folder is guaranteed to exist. might suggest a quick mkdir -p $fe_locales_dir to be explicit.
Member
Author
There was a problem hiding this comment.
good call, especially while it's not landed.
connorjclark
approved these changes
Sep 5, 2019
connorjclark
approved these changes
Sep 5, 2019
Collaborator
connorjclark
left a comment
connorjclark
left a comment
There was a problem hiding this comment.
/me bashfully approves
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparing for this to land:
https://chromium-review.googlesource.com/c/chromium/src/+/1784959
the only real change here is 51-56. the rest is refactors.