docs: update stale references to audits #9760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
patrickhulce
left a comment
patrickhulce
left a comment
There was a problem hiding this comment.
nice catch! not sure what spurs it now though :)
docs/readme.md
Outdated
| 'estimated-input-latency', | ||
| 'first-interactive', | ||
| 'first-cpu-idle', | ||
| 'consistently-interactive', |
Collaborator
There was a problem hiding this comment.
should probably update consistently-interactive, speed-index-metric, and kill estimated-input-latency if we're updating these now, or could just wait for when we really kill EIL :)
Collaborator
Author
the golden lantern file has refernces to |
connorjclark
changed the title
patrickhulce
reviewed
Oct 3, 2019
patrickhulce
approved these changes
Oct 3, 2019
Collaborator
patrickhulce
left a comment
patrickhulce
left a comment
There was a problem hiding this comment.
LGTM w/that change
patrickhulce
reviewed
Oct 3, 2019
Contributor
|
if we're updating should we just update to be consistent with the planned 6.0 set so we don't have to update again? They're just examples, doesn't seem like we're losing anything if we don't keep EIL around until it's removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
missed these in #4982