This repository was archived by the owner on Sep 3, 2022. It is now read-only.
Pick a random zone for CLI tests. #2004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the CLI end-to-end test so that it defaults to picking a random zone in the region 'us-west' instead of being hard-coded to 'us-west1-a'. The test will still honor the 'zone' config setting in gcloud if it is set; this only changes the behavior when that is not set.
yelsayd
reviewed
May 8, 2018
| def random_zone(): | ||
| zones_list = subprocess.check_output([ | ||
| 'gcloud', 'compute', 'zones', 'list', | ||
| '--filter=region~us-west', '--format=value(name)']).decode( |
There was a problem hiding this comment.
Should this be --format=value("name")?
There was a problem hiding this comment.
No; the string is already in quotes, so nested quotes would be passed directly to the format handler, which would not know what to do with them.
There was a problem hiding this comment.
Ah, what threw me off is I didn't know this actually executed as 'gcloud' 'compute'... etc (with the quotes). It fails for me without the quotes.
yelsayd
approved these changes
May 8, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the CLI end-to-end test so that it defaults to
picking a random zone in the region 'us-west' instead of being
hard-coded to 'us-west1-a'.
The test will still honor the 'zone' config setting in gcloud if
it is set; this only changes the behavior when that is not set.