This repository was archived by the owner on Oct 3, 2024. It is now read-only.
Add setOpenInNewTask() to AppSettingsDialog.Builder #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using setOpenInNewTask() for building the dialog, the app settings screen will be opened using an Intent that has the flag Intent.FLAG_ACTIVITY_NEW_TASK added before calling startActivityForResult(). Hence the settings Activity will not appear as a screen within the task of the activity it has been opened from but instead as a separate task that can be brought to front and back separately by the user.
samtstern
reviewed
Aug 6, 2018
| @Nullable String negativeButtonText, | ||
| int requestCode) { | ||
| int requestCode, | ||
| boolean openInNewTask) { |
There was a problem hiding this comment.
Even though the Builder method is setOpenInNewTask(boolean) I think we should make the AppSettingsDialog object take an int here called intentFlags rather than a boolean? What do you think? IMO it makes the purpose clearer and lets us add more flags in the future without adding any new fields.
The default can be 0.
There was a problem hiding this comment.
Yes, I thought about that option, too. I think it is a good idea
|
@sebkur thanks for the submission! |
instead of storing a boolean whether the settings screen should be opened using the Intent.FLAG_ACTIVITY_NEW_TASK flag, store an int that will be able to store different flags in the future, too.
|
I just pushed a new version |
|
@sebkur LGTM, thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added features as discussed in #230.
When using
setOpenInNewTask()for building the dialog, the app settings screen will be opened using an Intent that has the flagIntent.FLAG_ACTIVITY_NEW_TASKadded before calling startActivityForResult(). Hence the settings Activity will not appear as a screen within the task of the activity it has been opened from but instead as a separate task that can be brought to front and back separately by the user.