docs(adr): add A-11 — context-threading freeze and reduction plan#3423
Open
dimension-zero wants to merge 1 commit intogopasspw:masterfrom
Open
docs(adr): add A-11 — context-threading freeze and reduction plan#3423dimension-zero wants to merge 1 commit intogopasspw:masterfrom
dimension-zero wants to merge 1 commit intogopasspw:masterfrom
Conversation
Member
|
I think I have a pending branch somewhere that removes most of the context (ab)use already. I simply need to get it into shape and get it merged. I would leave this PR open as a reminder to finally do that, but I'm most likely not going to merge it. |
Records the three risks from the pkg/ctxutil pattern (silent failures, credentials-in-context, scope creep) and proposes a phased reduction: freeze new keys first, then extract display-config struct, then audit credential-adjacent keys. No code change. Signed-off-by: dimension-zero <zero@ditech.ai>
dimension-zero
force-pushed
the
docs/adr-context-threading
branch
from
1522ab6 to
3c1f108
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pkg/ctxutil/has grown to 30+ context keys threading config, terminal state, and credentials through the call stack.ARCHITECTURE.mdacknowledges this as non-idiomatic. No architectural decision records what the project intends to do about it, so the pattern continues to expand without a policy boundary.This PR adds
docs/adr/A-11-context-threading.mdwhich:No code change. The ADR is a decision record, not an implementation.
Related issue: #3417
Test plan
docs/adr/files (highest existing is A-10)